Files
markdown-converter/tests/main/ImageOperations.test.js
T
amitwh 0babf97f0e fix(image): lazy-load sharp with honest degradation so boot never fails
A missing/pruned @img/sharp-* binding made the top-level require('sharp')
crash src/main.js at startup, killing the packaged app before any window.
Load sharp through a cached lazy getter instead; when the native module
cannot load, executeOperation resolves the honest failure shape
{ success: false, error: 'Image operations unavailable: <sanitized>' }
(free of absolute paths), mirroring PDFOperations' Task-27 precedent.

Amit Haridas
2026-08-23 19:31:33 +05:30

125 lines
4.5 KiB
JavaScript

const sharp = require('sharp');
const fs = require('fs');
const os = require('os');
const path = require('path');
const ImageOperations = require('../../src/main/ImageOperations');
describe('ImageOperations', () => {
let tmpDir, inputPath;
beforeEach(async () => {
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'imgops_'));
inputPath = path.join(tmpDir, 'in.png');
await sharp({
create: { width: 100, height: 100, channels: 3, background: { r: 255, g: 0, b: 0 } },
})
.png()
.toFile(inputPath);
});
afterEach(() => fs.rmSync(tmpDir, { recursive: true, force: true }));
test('imageConvert converts PNG to JPEG', async () => {
const outputPath = path.join(tmpDir, 'out.jpg');
const result = await ImageOperations.imageConvert({ inputPath, outputPath, format: 'jpeg' });
expect(result.success).toBe(true);
expect(fs.existsSync(outputPath)).toBe(true);
const meta = await sharp(outputPath).metadata();
expect(meta.format).toBe('jpeg');
});
test('imageResize resizes to given width preserving aspect', async () => {
const outputPath = path.join(tmpDir, 'out.png');
await ImageOperations.imageResize({
inputPath,
outputPath,
width: 50,
height: null,
fit: 'inside',
});
const meta = await sharp(outputPath).metadata();
expect(meta.width).toBe(50);
});
test('imageRotate rotates by given angle', async () => {
const outputPath = path.join(tmpDir, 'out.png');
await ImageOperations.imageRotate({ inputPath, outputPath, angle: 90 });
const meta = await sharp(outputPath).metadata();
expect(meta.width).toBe(100); // 90deg on square stays square
});
test('imageCompress produces a smaller or equal-size JPEG at low quality', async () => {
const jpegPath = path.join(tmpDir, 'in.jpg');
await sharp(inputPath).jpeg({ quality: 100 }).toFile(jpegPath);
const outputPath = path.join(tmpDir, 'compressed.jpg');
await ImageOperations.imageCompress({ inputPath: jpegPath, outputPath, quality: 10 });
expect(fs.statSync(outputPath).size).toBeLessThanOrEqual(fs.statSync(jpegPath).size);
});
test('executeOperation dispatches to the correct function', async () => {
const outputPath = path.join(tmpDir, 'out.png');
const result = await ImageOperations.executeOperation('rotate', {
inputPath,
outputPath,
angle: 180,
});
expect(result.success).toBe(true);
});
test('unknown operation throws', async () => {
await expect(ImageOperations.executeOperation('bogus', {})).rejects.toThrow();
});
});
describe('ImageOperations when sharp fails to load (boot resilience)', () => {
// Reproduces the packaged-deb crash: the native @img/sharp-* bindings are
// missing/pruned, so require('sharp') throws. Importing ImageOperations must
// never crash the app at boot, and every operation must degrade honestly.
const dlopenErrorMessage =
'Could not load the "sharp" module using the linux-x64 runtime. ' +
'ERR_DLOPEN_FAILED: libvips-cpp.so.8.17.3: cannot open shared object file ' +
'(searched /opt/MarkdownConverter/resources/app.asar.unpacked/node_modules/@img/' +
'sharp-linux-x64/lib, /opt/MarkdownConverter/resources/app.asar/node_modules/@img/' +
'sharp-linux-x64/lib, ...)';
let isolatedModule;
beforeEach(() => {
jest.resetModules();
jest.doMock('sharp', () => {
throw new Error(dlopenErrorMessage);
});
jest.isolateModules(() => {
isolatedModule = require('../../src/main/ImageOperations');
});
});
afterEach(() => {
jest.dontMock('sharp');
});
test('requiring ImageOperations does not throw at import time', () => {
expect(() => require('../../src/main/ImageOperations')).not.toThrow();
});
test("executeOperation('convert') resolves to an honest unavailable failure", async () => {
const result = await isolatedModule.executeOperation('convert', {
inputPath: '/tmp/imgops-resilience-in.png',
outputPath: '/tmp/imgops-resilience-out.jpg',
format: 'jpeg',
});
expect(result).toEqual({
success: false,
error: expect.stringContaining('Image operations unavailable'),
});
});
test('the unavailable failure message carries no absolute paths', async () => {
const result = await isolatedModule.executeOperation('rotate', {
inputPath: '/tmp/imgops-resilience-in.png',
outputPath: '/tmp/imgops-resilience-out.png',
angle: 90,
});
expect(result.success).toBe(false);
expect(result.error).not.toMatch(/\/opt\/|\/tmp\/|[A-Z]:\\/);
});
});